@shivaprakash-sudo
Posted
Hello Paula,
The chart component looks good on desktop screen, but there are few issues with it as given below.
- The chart doesn't seem to be very responsive, because on small screens the chart width is becoming too small to hold the bar chart.
- I see that you're using a chart library to draw the chart, I tried using chart.js, but I couldn't make it work and look like the design, since I had no experience with it, so I dropped that and drew the chart from scratch using inline styling. The only suggestion I can provide here is that, if you're not experienced with the library, try not to use it and try to solve the problem in a different way. This way you'll get to learn many new things and also how to approach a problem without using libraries.
- Regarding the usage of semantic tags, you can wrap the chart component inside a
main
tag and the attribution inside afooter
tag. - Coming to the script, you can put JS code in a different file and link to it in the head section of the html file, this way the code looks more organized and easy to maintain.
I hope the above points are helpful and I hope to see more of your work, good luckš.
Marked as helpful