Expenses Chart w/ SASS & Vanilla JS

Community feedback

• 

  Eileen dangelo•1,600

  @Eileenpk

  Posted over 2 years ago

  Hi Robert! your project looks good, and this might be a helpful tip.

  In your HTML, you have nested <main> tags. It is best practice to only have one per page as screen readers and SEO uses the landmark tag to let users and bots know that this is the "main" content of the page.

  Also in your JS you have

  const dynamic = document.getElementById("chart");
  
  if (dynamic) {
      ...
  }
  

  I think you can take out the if statement because you have hard-coded the id=dynamic in your HTML and so it will always be a true value.

  Here is a link to learn more about semantic elements. https://www.w3schools.com/html/html5_semantic_elements.asp

  Hope you found this helpful!

  • Let's connect on LinkedIn! - @Eileenpk

  13

  Marked as helpful