Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

FAQ

sass/scss
Tatyane Gonçalves•520
@tatyanepgoncalves
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Olá, pessoal! 😄👋

Aqui está mais uma solução de desafio feito por mim.

As tecnologias utilizadas foram: 👩‍💻

  • HTML
  • CSS
  • SASS
  • JS

Estou aberta a receber dicas e feedbacks. Obrigada!!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Petrit Nuredini•2,860
    @petritnuredini
    Posted over 1 year ago

    Congratulations on completing the FAQ Accordion project! Your implementation showcases good HTML structure, CSS styling, and JavaScript functionality. Here are some best practices to enhance your project further:

    • Semantic HTML: Great use of semantic elements like <main>, <section>, and <picture>. Consider using <details> and <summary> tags for a more semantic accordion structure. Learn about semantic HTML here.

    • CSS Best Practices: Your CSS is well-organized. As your projects grow, consider adopting a naming convention like BEM for better readability and maintainability. Learn about BEM here.

    • Responsive Design: Ensure that the design is fully responsive and looks good on all devices. Use media queries to adjust layout and font sizes for different screen sizes. More on responsive design here.

    • Accessibility: Focus on making your website accessible, including keyboard navigation and proper ARIA roles for interactive elements. More about web accessibility can be explored here.

    • JavaScript Best Practices: Keep your JavaScript code clean and well-commented. Avoid using the same id for multiple elements as id should be unique. Consider using class instead. More on JavaScript best practices here.

    • Performance Optimization: Optimize images for faster loading times and better performance. More on image optimization here.

    Keep up the great work! Your dedication to crafting well-structured and interactive web pages is commendable. Continue exploring and experimenting with new techniques and technologies in your web development journey!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub