@0xabdulkhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
ACCORDION 🔴 :
- The best way to go with creating the accordion elements in this challenge would be with the
detailsandsummaryelements (or perhaps a combination of buttons and other elements).
- They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the
input,label&divelements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
- MDN's reference is a great place to start learning about the
detailsandsummaryelements if you are interested.
- If you have any questions or need further clarification, you can always check out
my submissionfor this challenge and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@kylekasprzyk
Posted
@0xAbdulKhalid Thank you for the helpful MDN reference!
@kylekasprzyk
Posted
@0xAbdulKhalid,
I am attempting to accomplish the bonus challenge by sticking to CSS alone. Is there a method for automatically closing the details and summary sections when another one is opened, without relying on JavaScript? Currently, they stay open until the user manually closes them.
@0xabdulkhalid
Posted
@kylekasprzyk
Actually there's no way to implement your idea without JavaScript, i know the bonus challenge is about solving without JavaScript.
But honestly we want to think apart from that, we are developers and problem solvers we can do whatever we want (if it is good to the software we building)
So go ahead and use JavaScript to get the desired result, Note; I also used the same method in my submission effectively
Let me know if you have any further doubts
