Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ accordion card using HTML and CSS

ah298 165

@ah298

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can i get a feedback on my HTML and CSS code? Is it clean? or hard to read? Thank you in advance!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, ah298! 👋

Nice work! 👍

I suggest,

  • Adding some alt text to your images for accessibility purposes.
  • Perhaps switching to a mobile-friendly layout a little sooner than 414px so that the content of the page doesn't look too squeezed right before the layout changes.
  • Your HTML looks organized! I think you should turn the "FAQ" title into a heading, however, in order to make your HTML more semantic.
  • I see you organized your Sass into different files, which is a good practice, too! Your comments are easy to read and understand (which is nice).

Keep coding (and happy coding, too)! 😁

0

ah298 165

@ah298

Posted

@ApplePieGiraffe thank u so much for the feedback. really appreciate it! :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord