Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

FAQ accordion card with React and Styled components

react, styled-components
Marina•850
@MarinaDur
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my final project. It got really complicated trying to make it responsive with the 3 images, it looked really bad so I changed it for big screens. I couldn't figure out how to make the questions to open smoothly with transition. Also couldn't figure out how to make the images to cut off at the adge on big screen. z-index didn't help, in dev tools it said that the z-index cannot apply because of position:static, but I didn't have position:static anywhere. Any ssuggestions and help will be really appriciated. Thank you

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Wendy•2,150
    @wendyhamel
    Posted over 1 year ago

    Hi Marina, Good job taking on this challange! You are right, making this one responsive is complicated.

    The smooth transitions for the answers is a problem. You can't transition dynamic height (height:auto), it needs absolute values. You can tinker around with it, but I often end up with it still beeing a bit janky. The position: static is the default position for all elements, if you don't specify a position yourself. To make this work in this challange you will need to work with position:relative and position: absolute. The element (a div for example) containing the image should have position:relative for the image with position:absolute to work. In this challange you will need two different locations for the two different images to show properly on different screen sizes.

    If you like to improve some more, you could work on the accessibility. If you use more semantic HTML elements, your solutions will be better accessible for screen readers and by keyboard. A <ul> with <li> items for example to show the questions and you could use the <details> element for the separate questions.

    Good places to learn:

    mozilla

    • about position
    • about transition
    • about accessibility
    • about the details element

    css tricks

    • about transitions with auto dimensions

    I do not want to reveal too much about how you could do this, it helps to figure out your own approach. But if you get stuck, Keep asking questions and don't give up!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub