Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

FAQ Accordion Card

Esteban•340
@estebanp2022
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


A bit of help if possible:

I struggled a bit with the toggle functionality. Toggle by itself works perfect (clicking the same question repeatedly opens/closes it), but in order to have only ONE accordion open at a time, I added a function to remove the previous 'active' classLists from the rest. Doing so, works like intended (only one accordion is open at a time), but it voided the toggle functionality... clicking on the individual question opens it but does not close it if clicked again (only closes if clicking a different question).

I hope this makes sense. If anyone is able to offer insight, I would so appreciate it!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • David•7,960
    @DavidMorgade
    Posted over 2 years ago

    Hello man congrats on finishing the challenge!! great job, the accordition issue is just a bit of logic warm up that will come with time, don't worry much about that.

    Here is my approach to solve the problem (for sure there is a better solution, but this should do the trick):

    1 - Give each of your faq elements an unique id (for example: faq1, faq2, faq3...)

    2 - Now that we have each faq element with an unique identifier, you can improve your removeActiveClasses function so it identifies when the clicked faq is the same that is open:

    function removeActiveClasses(elementId) {
      faqs.forEach((faq) => {
        if (elementId === faq.id) return;
        faq.classList.remove('active');
      });
    }
    

    2.1 - The element Id is the id of the faq div that should be pass to the function, then it compares it to the faq.id in your foreach loop and if its the same it will instantly return (cutting out the bad behaviour of not letting you close a faq by themself.

    3 - Last but not least you have to pass the current faq id from your event using some dom traversing or directly getting it from your forEach method:

    faqs.forEach((faq) => {
      faq.addEventListener('click', (e) => {
        removeActiveClasses(faq.id);
        faq.classList.toggle('active');
      });
    });
    

    3.1 - You could also use dom traversing with the e Event but this would be overkill since you already have your html faq element from the forEach method, just use faq.id in your eventListener and it should work

    Hope it helps, if you have any questions or need a pull request just ask!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub