Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

FAQ accordion

bem, accessibility
Davidson Aguiar•320
@davidsonaguiar
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


TIPS?

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Petrit Nuredini•2,860
    @petritnuredini
    Posted over 1 year ago

    Congratulations on completing your FAQ accordion project! It's a significant achievement, and the functionality and design look great. Here are some best practices recommendations to enhance your project:

    • Semantic HTML: Consider using more semantic HTML tags. For example, wrapping the FAQs in an <article> or <section> tag can improve readability and SEO. Learn about semantic HTML here.

    • CSS Variables: Excellent use of CSS variables for colors and font weights! To further improve, you might also consider using variables for spacing (padding/margins) and breakpoints for consistency. More on CSS variables here.

    • Accessibility: Ensure that the accordion is accessible. This includes keyboard navigation and proper ARIA roles. More about web accessibility can be found here.

    • Performance: Compress and optimize images to enhance loading times. Explore image optimization here.

    • Code Organization: Your CSS is well-organized. As your project grows, consider organizing it into multiple files or using a preprocessor like SASS for better maintainability. Learn about SASS here.

    • Responsive Design: Test your design across different devices to ensure it's fully responsive. You might need to adjust font sizes, images, or element spacing for smaller screens. Responsive design principles can be found here.

    Keep pushing your limits and exploring new aspects of web development. Your journey is shaping up impressively, and each project brings you one step closer to mastering frontend development!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub