Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

FAQ Accordion Solution ❓

Marco Musiol 🧑🏻•50
@musiolmarco
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Marzia Jalili•9,710
    @MarziaJalili
    Posted 7 months ago

    Well done buddy,

    Adjusments you could apply:

    • set the lines below in the body selector to centerize the card:
    body {
      display: grid;
      place-items: center;
      min-height: 100vh;
    }
    

    This ensures that the card will be centerize even when the answers are expanded.

    Get rid of two lines in style.css:

    1. line 29: margin: 10% 50px;
    2. line 36: margin-bottom: 15px;
    • Also, avoid using px for the font-size. It happens to cause some issues. You could use rem instead.

    Other than this your solution is spot on, man😎

    Marked as helpful
  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 7 months ago

    Hi @musiolmarco,

    I have some suggestions to help improve your project:

    Semantic Elements: I noticed you're using <div> elements. Consider replacing these with <footer> and <main> to align with HTML5 best practices. The <header> can be removed as it's semantically incorrect for this project. Typically, <header> should be used for elements like <nav> or a logo, at the top of a page.

    Animations: To make your project stand out more, consider adding animations. I recommend watching a YouTube tutorial on "accordion with animation" and then refactoring your code without external help. This will enhance the user experience and give your project a polished look.

    SEO Enhancements: Add SEO title and description tags to all your projects. Try sharing your project on Discord before and after implementing these changes to observe the differences in visibility and engagement. This practice will significantly improve SEO and click-through rates on real projects.

    Keep up the great work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub