Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ Accordion using html, css and JavaScript

Jason 120

@jasonalner

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Completed using html, css and javascript. First project completed with javascript, researching and adapting code from multiple sources. Any feedback most welcome!

Community feedback

@RenszCamacho

Posted

Hi Jason 👋🏻.Well done. 👏 This challenge is a bit tricky, and I like the way how you approached it.

Just a humble suggestion. 😊

  • Mobile version, doesn't look good, the card looks cut. Try to fix it.

  • If it had to position the card I would use flex-box rather than position fixed.@media (min-width: 1200px).flex-container

  • It would be much better if you use just classes in your CSS.

Happy Coding 🧑‍💻

2

Jason 120

@jasonalner

Posted

@RenszCamacho thanks Rensz!! I’ll take your suggestions on board and attempt it again soon. Thank you for your feedback and encouragement!

0

@RostykL

Posted

Hello, Learn about flex-box or CSS-grid. I didn't look at the code fully but I see that you used position absolute with the top property of 60% it's a bad practice since if you open it on Ipad Pro it goes down and I can't see the whole block. You can easily center a block using these three properties: display: flex; align-items: center; justify-content: center;

Also, you don't have a tablet version of your website. It goes from desktop to mobile but should go from desktop -> tablet -> mobile You should learn more about responsive design.

Overall you did well, I also did and do many mistakes when I do PSD to HTML but we are learning and that's ok.

1

Jason 120

@jasonalner

Posted

@RostykL Thanks so much for your feedback Rostyk, I have read a lot about flexbox but not used it in a project yet, so I will make sure I do in the next challenge. I really appreciate your comments.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord