@janegca
Posted
Hi Maria, overall the design looks good on my two screens. A few suggestions:
-
In your HTML, you are not using the 'body' tag, technically, all the elements (other than 'head') should be enclosed within it.
-
Not sure why you have placed your 'script' tag inside the footer. Normally it would go just before the 'body' close tag or up in the 'head' area with the 'defer' property. This is a nice piece of code, wish I had thought to do the same when I did this challenge.
Hope that's of some help. Nice work.
@itsfedoruk
Posted
hey Jane! thank you so much for reviewing my code and providing feedback.
-
that's a great catch! I've been working on the habit of including main/footer and other elements for accessibility – and I guess I missed the body tag chasing other tags 😅 so great catch, thank you.
-
I always put the script tag at the end of the document, e.g. before
</body>, to make sure it's functional and loads structure and style first and functionality second. having missed my body tags (as you pointed out), I enclosed it in the last element, e.g. footer.
thanks once again and happy holidays 🎄
