Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

FAQ Accordion with JavaScript

Craig Wolfe•190
@craigwolfe
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I would have to say I am most proud of figuring out the JavaScript. Understanding how to use forEach loops, swap images and use addEventListeners.

document.addEventListener('DOMContentLoaded', () => {
  const questions = document.querySelectorAll('.question');

  questions.forEach((question, index) => {
    const answer = document.getElementById(`answer${index + 1}`);
    const icon = question.querySelector('.toggle-icon');
//hide all answers on load
    const toggleAnswer = () => {
      if (answer.style.display === 'none') {
        answer.style.display = 'block';
        icon.src = 'https://github.com/myname/FAQ-Accordion/blob/main/assets/images/icon-minus.svg'; // Change to minus icon
      } else {
        answer.style.display = 'none';
        icon.src = 'https://github.com/myname/FAQ-Accordion/blob/main/assets/images/icon-plus.svg'; // Change to plus icon
      }
    };
//swaps the icon and shows the answer when clicked
    question.addEventListener('click', toggleAnswer);
//enter is pressed on the question the answer will toggle
    question.addEventListener('keydown', (event) => {
      if (event.key === 'Enter') {
        toggleAnswer();
      }
    });
  });
});

### What challenges did you encounter, and how did you overcome them?
One challenge I had was the path for swapping images in JavaScript will not display the images correctly in GitHub Pages. I had to retrieve the absolute path GitHub and use that in the JavaScript to get the images to render correctly.

### What specific areas of your project would you like help with?
I think I figured out everything I needed to on my own with internet resources.
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mirna Andrišić•540
    @mandrisic
    Posted 4 months ago

    actually you shouldn't have used javascript at all for this project, beacuse the challenge was to create an accordion with HTML nad CSS. it's best to use only HTML and CSS when you can, you just complicated everything for yourself

  • Craig Wolfe•190
    @craigwolfe
    Posted 4 months ago

    Actually I continued to have issues with the image. I thought I had a handle on it. But I realized it was still not correct.

    document.addEventListener('DOMContentLoaded', () => {
      const questions = document.querySelectorAll('.question');
    
      questions.forEach((question, index) => {
        const answer = document.getElementById(`answer${index + 1}`);
        const icon = question.querySelector('.toggle-icon');
    //hide all answers on load
        const toggleAnswer = () => {
          if (answer.style.display === 'none') {
            answer.style.display = 'block';
            icon.src = `${window.location.origin}/${FAQ-Accordion}/assets/images/icon-minus.svg`; // Change to minus icon
          } else {
            answer.style.display = 'none';
            icon.src = `${window.location.origin}/${FAQ-Accordion}/assets/images/icon-plus.svg`; // Change to plus icon
          }
        };
    //swaps the icon and shows the answer when clicked
        question.addEventListener('click', toggleAnswer);
    //enter is pressed on the question the answer will toggle
        question.addEventListener('keydown', (event) => {
          if (event.key === 'Enter') {
            toggleAnswer();
          }
        });
      });
    });
    

    ${window.location.origin}/${FAQ-Accordion}/assets/images/icon-plus.svg

    FAQ-Accordion is the name of my GitHub repo.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub