Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

faq-accordion

AmroGFarghali•50
@AmroGFarghali
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I dont know how to make it not have to click twice to show the menu

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jax Teller•670
    @piushbhandari
    Posted over 1 year ago

    i looked through your script and the reason why you have to click twice to get the accordions to open is because of your if statement.

    the reason it's not working is because your script is checking if the element has an INLINE style attribute of display: none. it doesn't check if the element has that style in your stylesheet.

    i would change your markup/styles/scripts to instead write class names i.e active and give the active class display: block. then in your if condition you can check if the element has the 'active' class. if it has the class, remove the active class, but if it doesn't then add the 'active' class.

    i did this in my project, you can look at my code here as an example of what i wrote above: https://github.com/piushbhandari/faqaccordion/blob/main/script.js

    let me know if you have any questions

    Marked as helpful
  • Jax Teller•670
    @piushbhandari
    Posted over 1 year ago
    • either use an <img/> for the pattern bg or a separate element inside the body tag for the pattern bg and set it via background-image. then set width: 100%; and make sure to set the height to what you see on the graphics. the reason i say this is because your whole layout gets ruined once you start going above the 1440px screen width

    • set cursor: pointer; to the button styles so that it's made clear those are buttons. then make sure to set hover/focus states to indicate that these are interactable

    • to improve on accessibility, you can add html attributes aria-expanded="true/false" on buttons and aria-hidden="true/false" for content depending on if the accordion is opened. this is for screen reader users so they'll have a better time interacting with your component

    hope this helps

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub