
Solution retrospective
I dont know how to make it not have to click twice to show the menu
Please log in to post a comment
Log in with GitHubCommunity feedback
- @piushbhandari
i looked through your script and the reason why you have to click twice to get the accordions to open is because of your if statement.
the reason it's not working is because your script is checking if the element has an INLINE style attribute of display: none. it doesn't check if the element has that style in your stylesheet.
i would change your markup/styles/scripts to instead write class names i.e active and give the active class display: block. then in your if condition you can check if the element has the 'active' class. if it has the class, remove the active class, but if it doesn't then add the 'active' class.
i did this in my project, you can look at my code here as an example of what i wrote above: https://github.com/piushbhandari/faqaccordion/blob/main/script.js
let me know if you have any questions
Marked as helpful - @piushbhandari
-
either use an <img/> for the pattern bg or a separate element inside the body tag for the pattern bg and set it via background-image. then set width: 100%; and make sure to set the height to what you see on the graphics. the reason i say this is because your whole layout gets ruined once you start going above the 1440px screen width
-
set cursor: pointer; to the button styles so that it's made clear those are buttons. then make sure to set hover/focus states to indicate that these are interactable
-
to improve on accessibility, you can add html attributes aria-expanded="true/false" on buttons and aria-hidden="true/false" for content depending on if the accordion is opened. this is for screen reader users so they'll have a better time interacting with your component
hope this helps
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord