Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

faq-accordion-card using html, sass, bootsrap and javascript

@Shashank1003

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my first project using javascript. Some tips to improve would be appreciated.

Community feedback

P
Grace 27,950

@grace-snow

Posted

Hi

This would be really great if you

  • made it keyboard interactive by using interactive elements for event listener items
  • used js to add / remove classes instead of inline styles
  • used css properties that can be transformed (display can't, but opacity, height etc can) which would allow you to add simple css animation effects
  • tweaked the styles on mobile so you can always see the image at the top and all content, even when mobiles are small or viewed landscape
  • changed body height to min-height
  • either didn't absolutely position your footer attribution, or added enough padding to the bottom of the body to ensure that footer never overlaps the main page content.

I hope these tips are helpful, best of luck with it

2

@Shashank1003

Posted

@grace-snow I understood your points and will try to incorporate them in future projects. These tips are really helpful as I was searching for ways to make websites look much pretty and interactive. Thanks a lot.

0

@piagja

Posted

nice work man!

one thing besides the tips of colleagues above is to add some easing when clicking in the arrow. Like arrow.element { transition: all 0.6s ease-in-out; }

1

@Shashank1003

Posted

@piagja Yes, I was also thinking that click feels different on my site. Thanks for the solution 😊

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord