FAQs using HTML, CSS, JS

Solution retrospective
i would be glad for a feedback
Please log in to post a comment
Log in with GitHubCommunity feedback
- @AGutierrezR
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
CSS and Styling:
- Consider using a
max-width
for thediv.box
element, I usedmax-width: 600px
- Implement CSS custom properties to define and utilize project colors more easily.
- Avoid using
px
forfont-size
, you could read this article to learn why. Letter spacing and line height must not be inpx
, userem
for all the font-related properties. - Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful - Consider using a
- @hensco95
Hello Ahmed. Amazing work, its really accessible. However I noticed a few things, whenever I expand a section from the accordion, the button(an image I suppose) vanishes, leaving only a broken img and an alt text of "mir". Asides that, you did well.
Marked as helpful - P@danielmrz-dev
Hello @AhmedAwad97!
Your solution is excellent!
I have one suggestion:
- You don't need to create a separate section to get the background pattern correctly. You can use both
background-color
andbackground-image
together. This will help you reduce unnecessary code.
I hope it helps!
Other than that, great job!
- You don't need to create a separate section to get the background pattern correctly. You can use both
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord