P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hello there, Harsh Patel! 👋
Great work on this challenge! 👍 Your solution looks good! 👏
A few suggestions I have are,
- Avoiding using
px
for setting the value offont-size
in your styles. Instead, use a responsive unit such asem
orrem
so that users will be able to change the size of the text in your site by changing the default font-size of their browser. It might also be worth setting the values for other properties such asmargin
orpadding
in those units so that your entire site will scale with the user's chosen default font-size. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video on the topic. - Avoiding setting specific heights for most of the elements in your page (especially wrapper or container elements). It's often better to simply allow the height of elements to be determined by their content (which is their default behavior) because then they will be just as high as they need to in order to accommodate what's inside them. You can always use margin or padding to add extra space around or inside those elements if desired. In this case, you can probably drop the
50%
height on the card's content and allow that element to be sized by the elements inside it.
Hope this helps. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful
2