Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

finish the product preview challenge with @media css

@rodjoker

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@HusseinSamy

Posted

Hello @rodjoker, 👋🏻

Awesome job on taking the first steps towards your dream!

I'm thrilled to see your engagement with this platform to enhance your design skills. I like your code organization. Though, I have some additions to make more clean:

1.Heading tags should increment accordingly for better web accessibility:

======= here should be the <h2> 
   <h3 class="product">PERFUME</h3>


=======  and here the <h3>      
     <h2 class="gabrielle">Gabrielle Essence Eau De Parfum</h2> 

*note: the main <h1> tag font-size could be smaller than the <h2> tag in some cases, but the order is crucial.

2.Use Bem for naming your styles.

3.Add meta tags:

<meta name="title" content="My Website">
<meta name="description" content="My Website Description">
<meta name="keywords" content="Some, Keywords, Here">

Hope you find it useful!😇

Keep up the fantastic work, and happy coding! 🚀

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord