Skip to content
Submitted over 1 year ago

First Challenge (built with React and SASS)

bem, react, sass/scss, typescript, vite
Scott Ning•170
@ning-sy210
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I completed this challenge months ago and never really thought about submitting it until now. This challenge itself doesn't really have much to go over, so I am looking for any general comments for areas that can be improved upon. For example (but not limited to the following):

  • Were the html tags used semantically appropriate?
  • How can the CSS be structured better?
Code

Please log in to post a comment

Log in

Community feedback

  • Bryan Li•3,530
    @Zy8712

    Your website look great. Good job!!

    The only thing I feel like you should change is to use <h1> tags for the title of the component instead of the <p> that you are using right now. The main reason being that screen readers may look for header tags, which your site is missing right now.

    Aside from that your code is well formatted and easy to follow along. Great work 👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord