Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

First challenge- Scan QR code component using Html & CSS

#materialize-css
Ana 20

@AnaSudame

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hi Ana, great work on this challenge! 😉

Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • use h1 for the title of card instead a simple p tag
  • not use <br> because it's for break line of text not for distance the element
  • remove all margin from .Recbox class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

Overall you did well 😁 Hope this help!

Marked as helpful

0

Ana 20

@AnaSudame

Posted

@denielden Thank you for your feedback! I will try the tips. I don't know anything about Flexbox yet as I have just started learning about html & css. Hope to get there soon.

1

@peterhannell

Posted

Hi :-)

Your CSS isn't linked properly. Make sure you include ./ before the path to your styles.css in your HTML head. Your code should read like this:

<link rel="stylesheet" href="./styles.css">

You also don't have any images in your github repository so you need to include them there.

Hope this helps!

0

Ana 20

@AnaSudame

Posted

@peterhannell thank you for your valuable feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord