First challenge- Scan QR code component using Html & CSS

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted about 3 years ago

  Hi Ana, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • use h1 for the title of card instead a simple p tag
  • not use <br> because it's for break line of text not for distance the element
  • remove all margin from .Recbox class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  01

  Marked as helpful
• 

  Peter Hannell•200

  @peterhannell

  Posted about 3 years ago

  Hi :-)

  Your CSS isn't linked properly. Make sure you include ./ before the path to your styles.css in your HTML head. Your code should read like this:

  <link rel="stylesheet" href="./styles.css">

  You also don't have any images in your github repository so you need to include them there.

  Hope this helps!

  01