Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

First project

Apag•20
@dizosos
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


It was difficult to find a solution to moving this to center

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zsolt Varjú•490
    @zsoltvarju
    Posted about 2 years ago

    Hello Apag!

    Great solution a near perfect replication of the design, love it!

    here are my suggestions:

    CSS:

    • Consider adding comments to your code, adding comments to your CSS code can help make it more understandable and maintainable, especially if you are working on a larger project. Consider adding comments to explain the purpose of each section of code or any notable features. I know thet it is not that big project but it is good to practice ;)
    • Try to use more descriptive class names. While the class names used in the code are functional, they could be more descriptive. Consider using class names that are more specific to the content they are styling, like card-container instead of container. Again it is good to practice and will repay you greatly later on.

    HTML:

    • Add** alt text** to images. The <img> tag includes the alt attribute, it should be filled with a descriptive text that describes the image content. This is useful for accessibility. If i remember correctly 20-30% percent of the internet users are disabled so it is very important to watch out for accesibility.
    • Close <h6> tags: The <h6> tag for "Challenge provided by" is not closed properly, which can cause issues with the layout of the page. Make sure all HTML tags are closed properly.
    • Try to maintain the hierarchy of the Heading tags, the web should always contain a H1 and after the H1 comes the H2 and so on.

    I would like to mention that you centered your card correctly, there are alternatives for it though.

    • Me myself i prefer to use display:grid and then place-items: center. it automatically centers the items both horizontally and vertically.
    • If you use flex you can use align-items:center combined with justify-content:center. One is centering it horizontally the other vertically

    I know i mentioned a lot of things here but none of them are a serious problem just a suggestion! :)

    Once more really great work and happy coding! :)

    Marked as helpful
  • Hassia Issah•50,390
    @Hassiai
    Posted about 2 years ago

    Replace <div class="container"> with the main tag and <h2> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

    Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

    Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

    <h6>Challenge provided by <a href="https://www.frontendmentor.io/home">Frontend Mentor</a> <h6>Coded by<a href="https://www.frontendmentor.io/profile/dizosos">Apag</a></h6> should be out of <div class="container"> and wrap in a footer tag.

    To center .container on the page using flexbox only instead of flexbox and margin, add justify-content: center to the body and remove the margin value in .container.

    body{
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
    }
    

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub