Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

First Submission - Vanilla

JacksonRudd•150
@JacksonRudd
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

This is the first time I felt like I understood flex. I understood that I needed to flex with flex-direction column.

I don't really understand what the best way to set the width is. Also the example said that the desktop and mobile widths were different but they seemed similar to me. I ended up using a max-width, but I imagine this is not correct.

There were many aspects I simply guessed on like the border radius.

What challenges did you encounter, and how did you overcome them?

It took me while to understand flex. And It took me a while to understand that the styling sometimes goes into the parent and not the child.

I struggled to see why div surrounding the image had some extra padding around the image. The reason turned out to be the paragraph element beneath the image was expanding to as much space as possible.

What specific areas of your project would you like help with?

I would like to know if my general use of flex was correct, and how to think about things like max-width of if there is a better way.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mohammed Ibrahim•640
    @MohammedOnGit
    Posted 9 months ago

    Hello JacksonRudd!!!

    Your HTML structure looks good and well-organized. Here are a few recommendations to improve accessibility and structure for readability

    • Semantic Elements: Use <main> and <section> tags to define content areas. Using <main> and <section> improves structure and helps screen readers.
    • Headings: Replace the first <p class="bold">with a heading tag like <h1> for better readability and accessibility.

    You did great. Keep it up!!!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub