Submitted over 3 years ago

First try on Mobile first approach using flex

@Ma1021

A solution to the 3-column preview card component challenge

Solution retrospective

I really cannot solve the problem of the using flex on the mobile device, but I am too stubborn on using the flex on everything. Will redo this next time.

Any feedback are welcome!!!!

Code

Please log in to post a comment

Community feedback

PhoenixDev22•16,830
@PhoenixDev22
Posted over 3 years ago
@Ma1021 I’m glad that it was beneficial . For question about <h1> it is recommended not to have more than one h1 on the page .

Screen reader users rely on the H1 to signal the start of the main content. If you have multiple H1s, it is disorienting. SEO experts often state that a web page must only have a single heading on level 1 (<h1>). According to them, like the <title> tag in the <head> of a page, this single heading on level one must describe the main content of the page. Because if there were more than one of them (SEO experts claim), search engines wouldn't be capable of deciding which one is the most important. Hopefully it’s clear .
Marked as helpful
PhoenixDev22•16,830
@PhoenixDev22
Posted over 3 years ago
Hello @Ma1021 ,

I have some suggestions regarding your solution:
- First of all , there's an issue with the live site of your solution .
- swap the buttons for anchor tags. Clicking those "learn more" buttons would trigger navigation not do an action so button elements would not be right. And for future, it is essential if you include a button in a form element without specifying it's just a regular button, it defaults to a submit button., though, so it's a good idea to make a habit of specifying the type.
- you can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). and make the other heading tags to h2.
```
.sr-only {
	border: 0 !important;
	clip: rect(1px, 1px, 1px, 1px) !important;
	-webkit-clip-path: inset(50%) !important;
		clip-path: inset(50%) !important; 
	height: 1px !important;
	margin: -1px !important;
	overflow: hidden !important;
	padding: 0 !important;
	position: absolute !important;
	width: 1px !important;
	white-space: nowrap !important;            
}
```
- border-radius and overflow hidden to the container that wraps the three cards.so you don't have to set it to individual corners.
- never have font size in px.
- You should use em and rem units .Both em and rem are flexible, scalable units. Using px won't allow the user to control the font size based on their needs.
- line heights should be unit less For accessibility concerns
Overall , your solution is good . Hopefully this feedback helps
Marked as helpful
Naveen Gumaste•10,420
@NaveenGumaste
Posted over 3 years ago
Hay ! Maggie Good Job on challenge
TsuneWeb•260
@TSune-web
Posted over 3 years ago
Hi Maggie, this is very neat and precise.
Ahmed ibrahim•370
@Ahmedhassanin12
Posted over 3 years ago
perfection👌✔

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord