Skip to content
Submitted over 3 years ago

First try with plain css

Guillermo Ochoa•40
@GuillermoOM
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I was wondering about whether I did right for any kind of display size, just to be sure if its correct to use px sizes from time to time (for padding and margin for example)

Code

Please log in to post a comment

Log in

Community feedback

  • Siege•520
    @idesmar

    Hi Guillermo! How was your first challenge with FEM? I hope you had fun.

    On using px for sizes, I normally just use rem for most sizes even padding and margin. Some uses em on the latter two but then again that comes down to your preference. I might use px for very small details like outline or borders.

    Regarding accessibility issues, you may want to look into using container tags like <header> <main> <section> <article> and <footer>. MDN is always a good source.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord