Skip to content
Submitted over 3 years ago

Fix QR Code using HTML & CSS

Daniel•30
@danielfrontendjourney
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What could I have done to have a more simplified code?

Code

Please log in to post a comment

Log in

Community feedback

  • Travolgi 🍕•31,300
    @denielden

    Hi Daniel, good job!

    For improve your code:

    • to make it look as close to the design as possible add text-align: center to card class
    • remove all margin from card class and body because with flex they are superfluous
    • remove margin and padding from html and body because with flex they are superfluous
    • add justify-content: center to body for center the card vertically
    • add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

    Overall you did well 😉

    Hope this help and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord