flex box , kustom properties , responsive

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hi, Sebastian T! 👋

  Good job on this challenge! 👍

  I suggest,

  • Adding the background images for this challenge to the body (rather than to pseudo-elements, since I don't think that's necessary and you won't have to worry so much about overflow issues then).
  • Adding overflow-x: hidden to the body to get rid of any unwanted horizontal scrolling on the page.
  • Adding a title to your page using the <title> tag.
  • Making sure the avatars in the testimonial cards don't become too small right before the layout changes from desktop to mobile (you might want to give them a min-width or something).

  Hope those tips help. 😉

  Keep coding (and happy coding, too)! 😁

  00
• 

  Fraser Watt•1,790

  @fraserwat

  Posted over 4 years ago

  Ah this is really nicely done!

  Couple of small changes, once you get down to ~350px width everything starts skewing to the left, I'd take a fiddle about with your positioning there.

  Also there's a couple of minor accessibility html issues flagged by the above report that should be really quick fixes.

  00