Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Flex box product card

Mohamed Hamdan•80
@Muhammed-Hamdan
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Used only flex box, can try recreating with grid

What challenges did you encounter, and how did you overcome them?
  1. Child elements of flex box are not pinned to parent, used overflow: hidden to solve it
  2. Used negative margin to align cart icon with text in button
What specific areas of your project would you like help with?

Please give suggestions to better organize the CSS and make it more readable

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • dkaffes•160
    @dkaffes
    Posted 5 months ago

    For the alignment of the cart icon with the text in button:

    you can create two elements: an <img> for the cart icon and a <span> for the text. If you enclose both elements in a <button>, then you can apply something like:

     display: flex;
      justify-content: center;
      align-items: center;
      gap: 0.5rem;
    

    on the <button>. In this way, both the cart icon and the text are perfectly aligned and centered (vertically and horizontally).

    For the use of a different image for the desktop and mobile version:

    you should better use the <picture> element. You can further investigate the <picture> element on the MDN Docs

  • nilikopo•110
    @nilikopo
    Posted 5 months ago

    u can use :root to store some known variables

    :root{
        /* given variables from style-guide.md */
        --color-dark-cyan: hsl(158, 36%, 37%);
        --color-cream: hsl(30, 38%, 92%);
        --color-very-dark-blue: hsl(212, 21%, 14%);
        --color-dark-grayish-blue: hsl(228, 12%, 48%);
        --color-white: hsl(0, 0%, 100%);
    
        /* my own variables */
        --border-radius: 10px;
        --padding-description: 2em;
        --padding-description-vertical: 1.5em;
        --padding-price-inline: 1.5em;
        --padding-button: 1em;
    }
    

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub