flex

Community feedback

• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hello @johns911, Congratulations on completing this challenge!

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  The html structure its fine, something you can do to improve the html markup its to replace some divs, note that you build all the structure using div blocks and these don’t have an particular meaning, for this reason its better you use meaningful tags like <article> in this example, for the cards replacing the divs, this way you have a tag that describes what it's inside the this html block.

  ✌️ I hope this helps you and happy coding!

  11

  Marked as helpful