Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

flex, justify-content, padding

simgeduru•50
@simgeduru
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Even though the appearance closely resembles the design in Figma, I am not sure if the functionality is appropriate

What challenges did you encounter, and how did you overcome them?

To make the design responsive, I initially gave each div height and width values in percentages to get the appropriate dimensions. I think this was the wrong approach. I resolved this by giving the first div inside the main the width and height values in pixels as seen in the design. At least, I think this is a solution. I am curious about how to solve such situations without using pixel values.

What specific areas of your project would you like help with?

I know not everything in the project is suitable. Since I don't fully understand what's right and what's wrong, I struggle with asking questions. Therefore, I am open to learning anything you can suggest or see as missing. Do you have any tricks for creating a basic layout? For example, should the mobile design be done first, or should the common points between desktop and mobile designs be identified and built upon from the start? I would be happy if you could provide information!

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Rachel Tschanz•210
    @rtdevcraft
    Posted about 1 year ago

    Hey Simgeduru!

    Just wanted to answer some of your questions and let you know it looks great!

    Pixel values are fine as long as the it would be the same pixel value across all screen types, which in this case it is.

    Doing the mobile size first is best practice, and then build up from there. As far as tips for building basic layouts, just depends on what you're building!

    Marked as helpful
  • Dmytro Angelovskyi•30
    @d1ma-angel
    Posted about 1 year ago

    Hi simgeduru,

    Your solution looks perfect. Great job. My personal two advices:

    • it is better to avoid using inline styles if possible
    • it is a lot of space in the bottom of the card
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub