Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Minimalist Perfume Card Using Flexbox

Gabriel Ferreiraโ€ข 150

@WillamiFerreira

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any Feedback Is Greatly Appreciated!

Community feedback

Lucas ๐Ÿ‘พโ€ข 104,560

@correlucas

Posted

๐Ÿ‘พHello Gabriel Ferreira, Congratulations on completing this challenge!

Your solution its almost done and Iโ€™ve some tips to help you to improve it:

Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

I saw that for some properties youโ€™ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

๐Ÿ‘จโ€๐Ÿ’ปHere's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

โœŒ๏ธ I hope this helps you and happy coding!

Marked as helpful

1
mโ€ข 140

@mhz-777

Posted

Looks good!

If I had to suggest anything for the sake of nit-picking it would be to add some margin and smaller mobile devices like the iPhone SE and the Samsung S10 for example.

Otherwise looks really nice good work :))

0

Gabriel Ferreiraโ€ข 150

@WillamiFerreira

Posted

@mhz-777 thanks for the feedback .๐Ÿ˜Š I'll take care about this on the next work.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord