Raymart Pamplona• 16,140
@pikapikamart
Posted
Hey, awesome work on this one. Layout in desktop looks really good, the layout responds well as well and the mobile layout is good.
Some suggestions would be:
- Avoid using
height: 100vh
on a large container like themain
element or abody
or just a large container. This makes the element's height limited to the remaining viewport/screen's height. Instead, you can just remove it or replace it withmin-height: 100vh
, this takes full viewport and will expand if it needs to. - The text after the
h1
could have just usep
tag and not a heading tag. - Lastly, adjust the breakpoint for mobile layout, showing the mobile layout at only 360px is very little. Also it would be great that you practice a lot using mobile first layout. This will really help you to manage breakpoints.
Just those above, really great job on this again.
1