Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox , CSS CUSTOM VARIABLES , DETAILS AND SUMMARY

Yokke 640

@Jexinte

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello all ,

This is my second attempt on this challenge I failed on the first one so any feedback would be appreciate .

Thanks for reading !

Community feedback

Chris 240

@ChristopherParke

Posted

Hey there. Looks good! One main issue I see is that you have desktop html, and mobile html. That's not best practices. What you should do instead is have one html structure, and change it with CSS using media queries. I see you have media queries, so I would just think about how you can change the layout using them, rather than hiding and showing html elements. Cheers

Marked as helpful

0

Yokke 640

@Jexinte

Posted

Hey @ChristopherParke,

Thanks for your feedback honestly I haven't thought about it like as mentionned it was my second try so I was just only focus on semantics and active states.

I'll keep your advice for my next challenge thanks again !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord