Raymart Pamplona• 16,140
@pikapikamart
Posted
Hey, awesome work on this one. Layout in general looks fine.
Some suggestions would be:
- Always have a
main
element that will wrap the whole main content of the webpage.main
elements helps users to properly navigate your content. - You don't have to use
margin
just to center the card properly. What you could have done is, on the.contenador
selector, usemin-height: 100vh
on it. Then just remove themargin
on the.tarjeta
selector. This way, your content will always be centered dynamically. - The
alt
for the card wave image should have been usingalt=""
on it, since it is only decoration. If an image acts just as a decoration, usealt=""
on it, but if the image adds content, then use a meaningfulalt
value. - The name of the person should have been a heading tag like
h1
orh2
. - The information below could have used
ul
element, since those are "list" of information about the user.
Just those mentioned, really great job on this one.
Marked as helpful
1
Gian Franco• 290
@gianback
Posted
@pikamart Oh thanks!!!!!
0