flexbox layout ,media queries

Please log in to post a comment
Log in with GitHubCommunity feedback
- @chrislara01
Great work! It really matched the original.
Some of the things you could improve in your solution are:
HTML:
-
Try to change some HTML element to more semantic ones. For the cards you could use and
<article>
element. Try to avoid<div>
as much as possible since is to much generic. -
Also, try to use continuous heading levels. You started using
<h1>
and<h2>
elements for the header, but you used<h4>
in the cards instead of<h3>
.
Responsiveness:
- This layout can be particularly difficult and I liked the hack you used to make the second and third element as a column. I would encourage you to try to enhance the responsiveness between mobile like devices and desktop devices, like in tablets since it seem that is not working properly. Since they don't give you a table like device design try to think of one yourself that could work in those devices like a two row, two cards layout.
A good work overall! Congrats!
-
- @AnjulAryal
all good
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord