Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox, media query

@Zeiyar-Lynn

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, I'm learning HTML and CSS. I want your advice for my HTML tag usages and CSS properties or anything you find scratchy. If you have time, I kindly request your feedback.

Community feedback

Hafizan Adli 1,190

@hafizanadli

Posted

Great work, it's close to design and responsive enough.

here my suggestions:

  • Avoid skipping heading levels: always start from <h1>, followed by <h2> and so on.
  • Use semantic HTML (main,section,header,footer etc) instead only using div tag

keep up the good work!

Marked as helpful

1

@Zeiyar-Lynn

Posted

@hafizanadli Thanks for your feedback!

0
P
Fluffy Kas 7,735

@FluffyKas

Posted

Hey,

First of all, congrats on your first upload, it's a really good start! But here are a few things you could do:

  1. You don't need to give your body element a class as there can only be one of them in each html document.

  2. The div you named main could actually be swapped for main element to be more semantic.

  3. Instead of pixels, most of the time it's better to use relative units like em, rem, ch, etc.

  4. If you want to improve responsiveness, you could use min-height, max-width, etc instead of setting these things in stone with width and height properties.

  5. Filling out your README is a nice way to show you put effort in your work and also to reflect on what you've learned ^^

1

@Zeiyar-Lynn

Posted

@FluffyKas Thanks for your feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord