Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox

@S-A-M-0

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Your suggestions mean's a lot

Community feedback

HYDROCODER 555

@HYDROCODER

Posted

Hey there! Good work. I would suggest the following if you don't mind:

  1. Put some comments in your css. It will be helpful to you as well as for anyone viewing your code.

  2. Do use ids, but rarely. ID's are very specific selectors and they can become messy when you have lot of elements in your HTML markup. For this challenge, I guess its fine but do be cautious about it. Use classes instead.

  3. Never set fixed heights and widths for anything unless something very specific.

  4. For the stats at the bottom, although it works, to be more semantic and meaningful, use ul and li's. Do learn more about semantic HTML to solve the accessibility issue.

Hope it helps :).

1

@S-A-M-0

Posted

@HYDROCODER that's awesome , thanks I appreciate your feedback :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord