Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox

Chris 740

@chrisbailey85

Desktop design screenshot for the Project tracking intro component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback will be appreciated. Thank you.

Community feedback

P
tediko 6,580

@tediko

Posted

Hello, Chris! 👋

Really good job on this challenge! What I would suggest is to change your logo img alt text to be empty since your logo is decorative image. In these cases, a null (empty) alt text should be provided (alt="") so that they can be ignored by assistive technologies, such as screen readers. Also, since you're using BEM i noticed that in main section you use good bem for elements and then you named h2 sub__heading. Be consistent with names, rename it to main__subheading for example. This is also the case for .cta. This div is still within your main so you can call it main__cta etc. This will pay off when you start using Sass.

Good luck with that, have fun coding! 💪

1

Chris 740

@chrisbailey85

Posted

@tediko thank you for the feedback. I've been trying to learn a bit more about accessibility lately so that information about the logo will be very helpful, just got to try and remember it. I always have issues choosing class names, although since I started using BEM it is getting a bit easier.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord