Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Flexbox

accessibility
Lance1891q•10
@Lance1891q
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ecem Gokdogan•9,380
    @ecemgo
    Posted over 2 years ago

    Some recommendations regarding your code that could be of interest to you.

    If you want that this solution is responsive, I suggest some techniques without using media query for this solution. Also, I recommend avoiding repetition in your code and not using styles that don't work.

    • If you want to make the card centered both horizontally and vertically, you'd better add flexbox and min-height: 100vh to the body
    body {
      /* overflow: hidden; */
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
    }
    
    • When you use flexbox in the body, you don't need to use flexbox in the .main-con to center the card
    • If you use max-width, the card will be responsive
    .main-con {
      background-color: hsl(0, 0%, 100%);
      /* height: 45%; */
      /* width: 15.7%; */
      max-width: 300px;
      padding: 15px;
      /* display: flex; */
      /* flex-direction: column; */
      /* justify-content: center; */
      /* align-items: center; */
      border-radius: 1rem;
    }
    
    • If you give height to text, it prevents the card will be responsive
    • You can update font-size and padding in this way
    • You can give margin-bottom to the .main-con .para to give a gap between the text and the bottom of the card
    .main-con .main-text {
      /* height: 17.5%; */
      /* font-size: 17px; */
      font-size: 20px;
      /* padding: 0 0px; */
      padding: 0 10px;
    }
    
    .main-con .para {
      /* height: 17.5%; */
      /* width: 100%; */
      /* font-size: 13px; */
      font-size: 16px;
      margin-bottom: 20px;
      padding: 0 10px;
    }
    
    • Finally, if you follow the steps above, the solution will be responsive
    • You'd better remove media queries and the styles below to avoid repetition
    /* .container {
        height: 100vh;
        width: 100vw;
        display: flex;
        justify-content: center;
        align-items: center;
    } */
    
    /* .main-con .img {
      height: 65%;
      width: 100%;
      border-radius: 1rem;
    } */
    
    /* .main-con .para p {
        font-size: 13px;
    } */
    

    Hope I am helpful. :)

  • EmmanuelUrias•130
    @EmmanuelUrias
    Posted over 2 years ago

    Great job looks great the only thing I have to add is that adding padding to the bottom of it would make it perfect.

  • Dinesh Kumar T•100
    @dineshjr
    Posted over 2 years ago

    Hi Lance everything is perfect on this design while the view is not perfect in desktop the component looks so small and on mobile view the image looks so not good so kindly fix this issues and repost it here again.

    Thanks & Regards

    Dinesh

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub