flexbox | tilt

Community feedback

• 

  P

  Freddy Santana•190

  @Creixz

  Posted about 3 years ago

  Hello my friend, Congratulations for finish the challenge, its seems pretty good, but I have some suggestions regarding your solution if you don't mind:

  • You can implement BEM's methodoly because it's a good practice and its not so difficult. Example: Instead of

  <div class="container">
      <div dclass="container">
          <img class="qrcode" src="./images/image-qr-code.png" alt="">
  

  use this

  <div class="container">
     <div class="card">
         <img class="qrcode" src="./images/image-qr-code.png" alt="qrcode" class: card__image>
  

  • Use max-width: 350px; in your card because its a mobile design and then use width: 100% in your card__image to adjust the image to the card

  Thank you for taking the time to read my feedback I hope it helps.

  10

  Marked as helpful