Flexbox to align the card

Community feedback

• 

  P

  Øystein Håberg•13,260

  @Islandstone89

  Posted 3 months ago

  HTML:

  • Every webpage needs a <main> element that wraps all of the content, except for <header> and footer>. This is vital for accessibility as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

  • Instead of an id, I recomend giving elements a class. This article explains when to use the id attribute.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Make a habit of including a modern CSS Reset at the top of your stylesheet.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • On *, margin: 0px and padding: 0px is usually written as margin: 0 and padding: 0. Whenever the value is zero, you don't need to include any units.

  • Move font-family to body.

  • On the body, change height to min-height: 100svh— this way, the content will not be cut off if it grows beneath the viewport.

  • Remove all widths and heights in px. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

  • We do want to limit the width of the card so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a significant accessibility issue, as it prevents the font size from scaling with the user's default browser setting. Use rem instead.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card: padding: 16px;

  • On the image, remove margin-top. Add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  01

  Marked as helpful
• 

  P

  jjurelvalenzuela•30

  @jjurelvalenzuela

  Posted 3 months ago

  • I am new here but I like how you spot your weaknesses and do better the next time.
  • I am sorry if my comment right now is not high-quality.
  • The live site is different here in the comparing section of the image.
  • Upon checking, the site, it is great for me. Good Job! Fellow developer

  01

  Marked as helpful