Fluid QR code component using plain CSS

Solution retrospective
When building your projects do you consider making your solution for all devices and zoom? In my opinion, it's impossible...
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@Islandstone89
Hello, good job on the challenge! Here are some tweaks to improve it even further.
HTML:
-
The alt text also needs to say where it leads (frontendmentor.io).
-
It's most common to have the "Challenge by" as a
<footer>
, placed underneath the card. The text also needs to be wrapped in a<p>
.
CSS:
-
It's good practice to include a CSS Reset at the top.
-
The
max-width
on the card looks good, but it should be in rem. 320px equals to 20rem. -
You only need to set
text-align: center
on the body - remove it elsewhere.
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord