Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

flyo-landing-page-with-two-column-layout-master/

@jaideep0101

Desktop design screenshot for the Fylo landing page with two column layout coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, everyone sharing my solution for fylo-landing-page-with-two-column-layout-master challenge please rate my work and your suggestion means a lot to me and really appreciable .

Community feedback

Tesla_Ambassadorโ€ข 2,980

@tesla-ambassador

Posted

Hey, this is a pretty fantastic solution! This is all I can say;

  1. Consider adding a little interaction to the email submit button. You can use a simple email validation function to solve this or incase you aren't yet comfortable with J.S yet, in your html, add "required" to the input tag of the email.
  2. For the accessibility issues, make sure that your heading tags are in sequential order i.e. (h2, h3, h4...), your document should contain only one main landmark, I recommend that you replace the second main landmark with a section or article. Lastly, your html elements should be contained in landmarks that means that all your divs, image tags, header tags(h1, h2...), buttons, etc. should be contained within landmarks like (main, section, article, etc.) When you fix accessibility issues, you make it easier for people that use screen readers to access/navigate your site.
  3. For your html issues, I recommend that you omit the font-weight on the html tag, usually, it's recommended that all your styling is done in you css, it helps a lot then also consider adding header tags (h2, h3...) to your section tag. This is usually required when you use a section or article landmark. Otherwise, this is very good work, keep up the good work and keep on coding! Kudos!
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord