@elidrissidev
Posted
Hey Frances! Hope you're doing great. First, I just wanna say congrats because you did an amazing job at making this as pixel-perfect as it can be! Unfortunately, regarding your question I cannot provide much help, personally I don't remember I had an issue like that but I could be wrong. Though I have some suggestions regarding your solution:
- Always make sure your
a
andbutton
elements have text inside them that describes where that link takes to or what that button does. In your solution for example, the social share buttons should probably be links btw because they will redirect somewhere, but should also have text inside them rather than just images. In this case the design does not show the text, so you can use the "visually hidden technique" which hides the text visually while still making it readable by screen readers. - For the social icons, I saw you're using
filter
to change the color of theimg
. It looked a bit confusing at first, so one way I'd do it is to inline thesvg
in your HTML. That way you can setfill="currentColor"
and they'll inherit the parent element'scolor
value so you can change it with ease.
That was all I have, I hope it was not overwhelming. Good luck!