Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Four Card Feature

#accessibility#bem
Lacey E 110

@laceeder

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Devmor 470

@devmor-j

Posted

Hey, this looks almost identical, great job 😎.

To clear that accessibility issue on report just wrap your whole content in a main tag.

If you prefer a more semantic html, one suggestion I can provide:

It's a best practice to put multiple heads [h1s, h2s, ...] inside a hgroup tag.

that being said:

<hgroup>
      <h1 class="line-one">
        Reliable, efficient delivery</h1>
      <h2 class="line-two">
        // Also this span seems superfluous
        // if `span` is used to indicate bold text, 
        // then `<b>...</b>` tag reads better in my opinion (or `strong` tag)
        <span>Powered by Technology</span>
      </h2>
</hgroup>

If you don't like hgroup simply do like so:

<h1 class="line-one">
        Reliable, efficient delivery
      <b class="line-two">
        Powered by Technology
      </b>
</h1>

I would personally go with the latter because I like having only one h1 on each page (article, post, ...). This will bring slightly better SEO results and helps robots to find content easier.

Hope these help, just for you to know you're doing great keep it up, cheers 😀

Marked as helpful

0

Lacey E 110

@laceeder

Posted

@devmor-j Doh! I totally forgot the <main> tag! Thank you (and the report) for pointing that out! I've updated my code to reflect the addition :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord