Submitted over 2 years ago

Four card feature component

Borcho•170

@AlexdelCarmen

A solution to the Four card feature section challenge

Preview Code

Solution retrospective

All feedback is welcome, thanks!

Code

Please log in to post a comment

Community feedback

Samuel Llibre Santos•400
@Zyruks
Posted over 2 years ago
Hey nicely done this challenge but... Yeah there is always a but lol

You need to modify some tags on your code to get more semantic tags and make your HTML more accessible.

Gonna help you out a bit.

Your Code
```
Line 27     <div class="main-title thin">Reliable, efficient delivery</div>
Line 28     <div class="main-title bold">Powered by Technology</div>
```
What i would do is:
```
<h1 class="main-title"> Reliable, efficient delivery <br />
<span class="thin">Powered by Technology </span>
 </h1>
```
Later on on line 34 wrap the entire card-wrapper div with a main tag
```
<main>
     <div class="card-wrapper">
     </div>
</main>
```
With this all your code should pass the accessibility report ;)

If you need any help or didn't understand something just ask me I'm happy to help

Keep going and keep learning.
Marked as helpful
Adriano•42,890
@AdrianoEscarabote
Posted over 2 years ago
Hi Borcho, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

2- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:
```
<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>
```
ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
```
<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>
```
It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord