@artimys
Posted
Hi Enayar, you did great job. You were able to capture the details really well. I do agree with you on a tablet view for the transition from mobile to desktop. I'll add some feedback.
- Good use of using BEM. I would only suggest adding the
--modiferto your class that overwrites the color. Examplecard__top-color blue_colortocard__top-color card__top-color--blue. Though I do admit your method looks much cleaner for this situation.
Just a note. Be aware of "specificity" when building out your selectors (example below of what I mean). Sometimes when they nest too deep in larger projects. It can be difficult to over override styles and manage. BEM is a way to help know which classes go along with each other which you already have a start on.
body main .cards .card .card__description { <-- these guys I'm referring to
}
Great job, keep it up and keep on coding!! 👍
@RayaneBengaoui
Posted
Thank you @artimys for this feedback ! 🙂
I recently started to read about BEM methodology and found it very interesting, so I try to use it more and more but I'm not confident yet. Next time I won't forget to use a --modifier.
For the specificity I totally get your point. But I really like how I can nest everything with SASS because I find it very clean on the "code side" (personnal preference). So do you suggest to nest less so that I can reduce my specificity ?
I'll take a look on your code to see how you process, thanks again 👍
