Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Four card feature master

NATNAEL GETACHEW ASEFA•100
@Eng-Natole
A solution to the Four card feature section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I’m proud of successfully implementing a clean and responsive layout using Flexbox. Next time, I’d focus on optimizing my code structure and improving accessibility features.

What challenges did you encounter, and how did you overcome them?

A challenge I faced was aligning the card components correctly across different screen sizes. I overcame this by refining my Flexbox usage and adjusting spacing with CSS custom properties.

What specific areas of your project would you like help with?

I’d appreciate feedback on improving my mobile-first workflow and making my CSS more efficient and scalable. Any tips on enhancing visual hierarchy and accessibility would also be valuable.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Howslifem8•100
    @Howslifem8
    Posted 6 months ago

    Hello, your final product looks great ! I do have some recommendations for your semantic structure though. Firstly, within any <div> your header elements should be in hieratical order. For example within your <header> you used two <h1> elements. The semantic approach would've been using a single <h1> for the top-first line then a <h2> for the second and a <p> for the longer text. Using CSS you then change how the <h> text appears.

    Additionally, I believe you could've used less classes to structure your code better. In your code it seems you utilized 5 unique classes (container, content, combiner, card & card-component), I believe you could've combined card & card-component, and scrapped the combiner class. I personally used 2 classes (Container & Card). For this project the combiner class could've been scrapped if you used your container class for only the card section, excluding the <header> that's pre-placed with html. The html also places the card in it's respective column so if you put 2 cards inside 1 <div> that means they share a column. Lastly, the card & card-component could be combined.

    All-in-all you got the job done and it looks sleekly professional so awesome job. Hope the feedback helps, keep on going !

    Marked as helpful
  • k-mardine•60
    @k-mardine
    Posted 6 months ago

    you just need practice your eyes to make same desgin you have to be proud keep going

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub