@gsterczewski
Posted
Hello dannebrob 👋, my name is Grzegorz.
I like your solution, it's looking pretty good.
I have a few small observations.
-
Your
<p>
element right now is too narrow on desktop, maybe consider giving it more space by reducingmargin-left
andmargin-right
on.info
-
There is not enought vertical space between
.info
and.card-container
, you can easily fix it by addingmargin-bottom
ormargin-top
-
I would rethink using
vw
andvh
as a unit for margins, since it cause problems with responsiveness (try to resize page to 1024x1366 and see what happens) -
Maybe figure out other way to limit width on
.info
without those horizontal margins.
Other than that, I like it.
I hope my sugestions will be useful to you
Keep up the good work! 💪
See you on the coding trail 😉
Cheers!
Marked as helpful
@dannebrob
Posted
@GSterczewski Thank you for the feedback! This really helps!