Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Four card feature section

dannebrob•130
@dannebrob
A solution to the Four card feature section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


My second Frontend Mentor challange.

Please give me any feedback you can! Thanks in advance!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grzegorz Sterczewski•680
    @gsterczewski
    Posted almost 4 years ago

    Hello dannebrob 👋, my name is Grzegorz.

    I like your solution, it's looking pretty good.

    I have a few small observations.

    • Your <p> element right now is too narrow on desktop, maybe consider giving it more space by reducing margin-left and margin-right on .info

    • There is not enought vertical space between .info and .card-container, you can easily fix it by adding margin-bottom or margin-top

    • I would rethink using vw and vh as a unit for margins, since it cause problems with responsiveness (try to resize page to 1024x1366 and see what happens)

    • Maybe figure out other way to limit width on .info without those horizontal margins.

    Other than that, I like it.

    I hope my sugestions will be useful to you

    Keep up the good work! 💪

    See you on the coding trail 😉

    Cheers!

    Marked as helpful
  • Account deletedPosted over 2 years ago

    Hey @dannebrob, some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (Matt Studdert recommend this layout)
    <body>
       <header></header>
       <main>
          <section>
                <div class="supervisor-card"></div>
                <div class="team-card"></div>
                <div class="karma-card"></div>
                <div class="calculator-card"></div>
          </section>
       </main>
    </body>
    

    The Header Element represents introductory content.

    The Main Element identifies the main content of the document.

    The Section Element can be used to wrap content that is related to each other.

    And since none of the cards make sense on their own, a simple Div will do for each card.

    • The heading is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.

    • Add a third layout to make the transition from mobile 📱 -> desktop 🖥 views smoother.

    • The icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

    Happy Coding! 👻🎃

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub