@gretagr
Posted
Hey, congrats on your first solution! I think your code is actually quite neat! You use HTML5 tags really nicely! (maybe you don't need the div's around article tags tho). However, I have some thoughts about the design itself:
- Your cards are way too big.
- There is no spacing around cards when the screen gets smaller.
- Heading text overlaps text below it on a mobile screen, and cards do not fit the screen.
- As mentioned before - you forgot to use given fonts.
Now, it might seem to be not so much of an issue (the code is good, right?), but as a frontend developer, your goal is to get the website looking as close to the design as possible, so I thought this kind of feedback might be useful too :)
Good luck on your next projects, you're off with a good start!
@avisikhsan
Posted
@gretagr thank you for the correction and advice