Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

four card feature section master

ibrahimβ€’ 55

@ibrahimano

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello world! It's been a long time since I submitted a challenge, and I'm excited to hear any feedback from you so feel free to write one. While working on this challenge I wasn't sure what to use with those four cards so at first, i tried css grid, but I couldn't arrange those four cards in the same way so I changed it to flexbox and yup finally It worked. My questions : should i have used the css grid? is it better than flexbox in this case. what do you think?

Community feedback

Naveen Gumasteβ€’ 10,480

@NaveenGumaste

Posted

Hello ibrahim ! Congo πŸ‘ on completing this challenge

Let's look at some of your issues, shall we:

  • Add Main tag after body <main class="container"></main>

  • To center the card vertically

min-height: 100vh;
display: flex;
justify-content: center
align-item: center;
  • Always use h1 first and then h2, h3 and so on

  • Headings should only increase by one use h1 first then h2 etc..

  • Consider using h2-h6 elements to add identifying headings to all sections.

  • Always use the "alt attribute" and write what img is , and if the img is for decorative then leave it empty but always add it with alt.

happy CodingπŸ˜€

Marked as helpful

0

ibrahimβ€’ 55

@ibrahimano

Posted

@Crazimonk thank you! I fixed those issues, that was really helpful for the main tag am i using it in the wrong way?

1
Naveen Gumasteβ€’ 10,480

@NaveenGumaste

Posted

@ibrahimano I saw your HTML code, using multiple h1 is not good practice use h2 h3 and then style them in css

and for main tag its fine what you are using bt.. try to avoid it and keep main tag just for the sake of semantic structure .

0
Shashree Samuelβ€’ 9,260

@shashreesamuel

Posted

Hey ibrahimano good job completing this challenge. Keep up the good work

Your solution looks seemingly close to the design however I have some suggestions

  • The title, description and the card headings are supposed to be in a lighter font color. I suggest referring back to the style-guide.md file just to be sure.

  • In terms of the cards I think in comparison with the design they are supposed to be a bit wider.

  • The paragraph below the subtitle needs some margin from the top. You can achieve this using the margin-top property.

In terms of your accessibility issues

  • headings must increase by one level which means if you have a <h1> tag then the preceding tag should be a <h2> tag.

  • images need alternative text. This means that your image tag needs an alternative description, you simply have to mention the alt attribute and provide a description of the image. This description will become useful to screen-readers or if the image is referenced incorrectly by giving users an insight on what the image should be

In terms of your html validation errors once you correct your accessibility errors your validation errors will be resolved.

I hope this helps

Cheers Happy coding πŸ‘

Marked as helpful

0

ibrahimβ€’ 55

@ibrahimano

Posted

@TheCoderGuru Thank you for your feedback it really helped me improve my code

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord