four card feature section master using css grid

Solution retrospective
It's the first time I've actually used grid. Is it bad practice to use grid generators?
Please log in to post a comment
Log in with GitHubCommunity feedback
- @correlucas
👾Fala Thais, tudo bem? Parabéns pelo desafio!
Acabei de abrir o preview da sua solução e achei tudo mto bom, tem poucos detalhes pra melhorar. Aqui umas dicas:
1.O valor da sombra do componente está um pouco forte, você pode melhorar isso colocando menos
opacity
e maisblur
, aqui um valor bom pra essa sombra:box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 5%);
Esse site aqui te ajuda a criar o design da sombra e depois basta copiar e colar o codigo dentro do CSS: https://www.cssmatic.com/box-shadow
👋 Espero ter ajudado e continue no foco!
Marked as helpful - @zeerobit
- i would advise not to use generators for grid but instead try to do it yourself, this will help you understand how grid works and how to use it to achieve different layouts. This challenge is a really good example where you can use grid-areas.
- px is not scalable, use rem instead wherever possible
- to position the image it'd be better if you use flexbox on the cards (boxes) then you could use align-self to position the images which can be done with one image selector instead of having to target the image for each box separately therefore you'd end up using less codes
overall looks good thought I'd share my feedback, hope it helps
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord